Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create()

2018-01-19 Thread David Miller
From: Lorenzo Bianconi Date: Wed, 17 Jan 2018 11:41:20 +0100 > Remove the switch block in l2tp_nl_cmd_session_create() that > checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and > L2TP_PWTYPE_PPP are currently supported and no actual checks are > performed. Moreover the L2TP_PWTY

Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create()

2018-01-17 Thread Guillaume Nault
On Wed, Jan 17, 2018 at 11:41:20AM +0100, Lorenzo Bianconi wrote: > Remove the switch block in l2tp_nl_cmd_session_create() that > checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and > L2TP_PWTYPE_PPP are currently supported and no actual checks are > performed. Moreover the L2TP_P

[PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create()

2018-01-17 Thread Lorenzo Bianconi
Remove the switch block in l2tp_nl_cmd_session_create() that checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and L2TP_PWTYPE_PPP are currently supported and no actual checks are performed. Moreover the L2TP_PWTYPE_IP/default case presents a harmless issue in error handling (break i