Re: [PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

2017-02-22 Thread David Miller
From: Ridge Kennedy Date: Wed, 22 Feb 2017 14:59:49 +1300 > While destroying a network namespace that contains a L2TP tunnel a > "BUG: scheduling while atomic" can be observed. > > Enabling lockdep shows that this is happening because l2tp_exit_net() > is calling l2tp_tunnel_closeall() (via l2tp

Re: [PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

2017-02-22 Thread Guillaume Nault
On Wed, Feb 22, 2017 at 02:59:49PM +1300, Ridge Kennedy wrote: > While destroying a network namespace that contains a L2TP tunnel a > "BUG: scheduling while atomic" can be observed. > To fix this, move the call to l2tp_tunnel_closeall() out of the RCU > critical section, and instead call it from l

[PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

2017-02-21 Thread Ridge Kennedy
While destroying a network namespace that contains a L2TP tunnel a "BUG: scheduling while atomic" can be observed. Enabling lockdep shows that this is happening because l2tp_exit_net() is calling l2tp_tunnel_closeall() (via l2tp_tunnel_delete()) from within an RCU critical section. l2tp_exit_net(