Re: [PATCH net-next] ipv6: Check if route exists before notifying it

2019-06-19 Thread David Ahern
On 6/19/19 1:40 PM, Ido Schimmel wrote: > On Wed, Jun 19, 2019 at 01:10:08PM -0600, David Ahern wrote: >> On 6/19/19 11:55 AM, Ido Schimmel wrote: >>> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c >>> index 1d16a01eccf5..241a0e9a07c3 100644 >>> --- a/net/ipv6/ip6_fib.c >>> +++ b/net/ipv6/ip6

Re: [PATCH net-next] ipv6: Check if route exists before notifying it

2019-06-19 Thread Ido Schimmel
On Wed, Jun 19, 2019 at 01:10:08PM -0600, David Ahern wrote: > On 6/19/19 11:55 AM, Ido Schimmel wrote: > > diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c > > index 1d16a01eccf5..241a0e9a07c3 100644 > > --- a/net/ipv6/ip6_fib.c > > +++ b/net/ipv6/ip6_fib.c > > @@ -393,6 +393,8 @@ int call_fib

Re: [PATCH net-next] ipv6: Check if route exists before notifying it

2019-06-19 Thread David Ahern
On 6/19/19 11:55 AM, Ido Schimmel wrote: > diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c > index 1d16a01eccf5..241a0e9a07c3 100644 > --- a/net/ipv6/ip6_fib.c > +++ b/net/ipv6/ip6_fib.c > @@ -393,6 +393,8 @@ int call_fib6_multipath_entry_notifiers(struct net *net, > .nsiblings =

[PATCH net-next] ipv6: Check if route exists before notifying it

2019-06-19 Thread Ido Schimmel
From: Ido Schimmel When user space sends invalid information in RTA_MULTIPATH, the nexthop list in ip6_route_multipath_add() is empty and there is no route to notify. The code that emits the netlink notifications correctly checks if the route is not NULL, but I missed that for the in-kernel noti