Re: [PATCH net-next] ipv4: frags: precedence bug in ip_expire()

2018-08-06 Thread David Miller
From: Dan Carpenter Date: Mon, 6 Aug 2018 22:17:35 +0300 > We accidentally removed the parentheses here, but they are required > because '!' has higher precedence than '&'. > > Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") > Signed-off-by: Dan Carpenter Ugh, good catch, applied,

Re: [PATCH net-next] ipv4: frags: precedence bug in ip_expire()

2018-08-06 Thread Peter Oskolkov
Ack. Thanks, Dan! On Mon, Aug 6, 2018 at 12:17 PM Dan Carpenter wrote: > > We accidentally removed the parentheses here, but they are required > because '!' has higher precedence than '&'. > > Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") > Signed-off-by: Dan Carpenter > > diff --gi

[PATCH net-next] ipv4: frags: precedence bug in ip_expire()

2018-08-06 Thread Dan Carpenter
We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 0e8f8de77e71..7cb7ed761d8c 1