Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-24 Thread Xin Long
On Tue, Nov 24, 2020 at 6:23 AM Alexander Duyck wrote: > > On Mon, Nov 23, 2020 at 1:14 AM Xin Long wrote: > > > > On Sat, Nov 21, 2020 at 12:10 AM Alexander Duyck > > wrote: > > > > > > On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > > > > > > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Du

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-23 Thread Alexander Duyck
On Mon, Nov 23, 2020 at 1:14 AM Xin Long wrote: > > On Sat, Nov 21, 2020 at 12:10 AM Alexander Duyck > wrote: > > > > On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > > > > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck > > > wrote: > > > > > > > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-23 Thread Xin Long
On Sat, Nov 21, 2020 at 12:10 AM Alexander Duyck wrote: > > On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck > > wrote: > > > > > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > > > > > > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Du

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-20 Thread Alexander Duyck
On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck > wrote: > > > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > > > > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck > > > wrote: > > > > > > > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-20 Thread Xin Long
On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck wrote: > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck > > wrote: > > > > > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > > > > > > > This patch is to let it always do CRC checksu

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-19 Thread Alexander Duyck
On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck > wrote: > > > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > > by removing CRC flag from the dev features i

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Xin Long
On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck wrote: > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > by removing CRC flag from the dev features in gre_gso_segment() for > > SCTP over GRE, just as it does in Com

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Xin Long
On Thu, Nov 19, 2020 at 12:44 AM Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 14:14:49 +0800 Xin Long wrote: > > On Wed, Nov 18, 2020 at 8:29 AM Jakub Kicinski wrote: > > > On Mon, 16 Nov 2020 17:15:47 +0800 Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segme

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Alexander Duyck
On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > This patch is to let it always do CRC checksum in sctp_gso_segment() > by removing CRC flag from the dev features in gre_gso_segment() for > SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support > sctp over udp in skb_udp_tunnel_se

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 14:14:49 +0800 Xin Long wrote: > On Wed, Nov 18, 2020 at 8:29 AM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 17:15:47 +0800 Xin Long wrote: > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > > by removing CRC flag from the dev features in gre_gso

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-17 Thread Xin Long
On Wed, Nov 18, 2020 at 8:29 AM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 17:15:47 +0800 Xin Long wrote: > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > by removing CRC flag from the dev features in gre_gso_segment() for > > SCTP over GRE, just as it does in Commit

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 17:15:47 +0800 Xin Long wrote: > This patch is to let it always do CRC checksum in sctp_gso_segment() > by removing CRC flag from the dev features in gre_gso_segment() for > SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support > sctp over udp in skb_udp_tunnel_se

[PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-16 Thread Xin Long
This patch is to let it always do CRC checksum in sctp_gso_segment() by removing CRC flag from the dev features in gre_gso_segment() for SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support sctp over udp in skb_udp_tunnel_segment") for SCTP over UDP. It could set csum/csum_start in