Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Willem de Bruijn
On Tue, Jun 30, 2020 at 2:57 PM Tom Herbert wrote: > > On Tue, Jun 30, 2020 at 9:52 AM Willem de Bruijn > wrote: > > > > On Tue, Jun 30, 2020 at 12:41 PM Tom Herbert wrote: > > > > > > On Tue, Jun 30, 2020 at 9:16 AM Eric Dumazet > > > wrote: > > > > > > > > > > > > > > > > On 6/30/20 6:57 AM,

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Tom Herbert
On Tue, Jun 30, 2020 at 9:52 AM Willem de Bruijn wrote: > > On Tue, Jun 30, 2020 at 12:41 PM Tom Herbert wrote: > > > > On Tue, Jun 30, 2020 at 9:16 AM Eric Dumazet wrote: > > > > > > > > > > > > On 6/30/20 6:57 AM, Willem de Bruijn wrote: > > > > On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruij

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Willem de Bruijn
On Tue, Jun 30, 2020 at 12:41 PM Tom Herbert wrote: > > On Tue, Jun 30, 2020 at 9:16 AM Eric Dumazet wrote: > > > > > > > > On 6/30/20 6:57 AM, Willem de Bruijn wrote: > > > On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruijn > > > wrote: > > >> > > >> On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Willem de Bruijn
On Tue, Jun 30, 2020 at 12:16 PM Eric Dumazet wrote: > > > > On 6/30/20 6:57 AM, Willem de Bruijn wrote: > > On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruijn > > wrote: > >> > >> On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: > >>> > >>> On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet > >>>

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Tom Herbert
On Tue, Jun 30, 2020 at 9:16 AM Eric Dumazet wrote: > > > > On 6/30/20 6:57 AM, Willem de Bruijn wrote: > > On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruijn > > wrote: > >> > >> On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: > >>> > >>> On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet > >>> w

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Eric Dumazet
On 6/30/20 6:57 AM, Willem de Bruijn wrote: > On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruijn > wrote: >> >> On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: >>> >>> On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet wrote: On 6/29/20 2:30 PM, Willem de Bruijn wrote: > O

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-30 Thread Willem de Bruijn
On Mon, Jun 29, 2020 at 10:19 PM Willem de Bruijn wrote: > > On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: > > > > On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet wrote: > > > > > > > > > > > > On 6/29/20 2:30 PM, Willem de Bruijn wrote: > > > > On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet >

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Willem de Bruijn
On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: > > On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet wrote: > > > > > > > > On 6/29/20 2:30 PM, Willem de Bruijn wrote: > > > On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet > > > wrote: > > >> > > >> > > >> > > >> On 6/29/20 9:57 AM, Willem de Bruijn

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Tom Herbert
On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet wrote: > > > > On 6/29/20 2:30 PM, Willem de Bruijn wrote: > > On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet wrote: > >> > >> > >> > >> On 6/29/20 9:57 AM, Willem de Bruijn wrote: > >>> From: Willem de Bruijn > >>> > >>> ICMP messages may include an ex

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Tom Herbert
On Mon, Jun 29, 2020 at 2:15 PM Eric Dumazet wrote: > > > > On 6/29/20 9:57 AM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > ICMP messages may include an extension structure after the original > > datagram. RFC 4884 standardized this behavior. > > > > It introduces an explicit origi

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Eric Dumazet
On 6/29/20 2:30 PM, Willem de Bruijn wrote: > On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet wrote: >> >> >> >> On 6/29/20 9:57 AM, Willem de Bruijn wrote: >>> From: Willem de Bruijn >>> >>> ICMP messages may include an extension structure after the original >>> datagram. RFC 4884 standardized t

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Willem de Bruijn
On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet wrote: > > > > On 6/29/20 9:57 AM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > ICMP messages may include an extension structure after the original > > datagram. RFC 4884 standardized this behavior. > > > > It introduces an explicit origi

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Eric Dumazet
On 6/29/20 9:57 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > ICMP messages may include an extension structure after the original > datagram. RFC 4884 standardized this behavior. > > It introduces an explicit original datagram length field in the ICMP > header to delineate the orig

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Willem de Bruijn
On Mon, Jun 29, 2020 at 4:34 PM Tom Herbert wrote: > > On Mon, Jun 29, 2020 at 12:23 PM Willem de Bruijn > wrote: > > > > From: Willem de Bruijn > > > > ICMP messages may include an extension structure after the original > > datagram. RFC 4884 standardized this behavior. > > > > It introduces an

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Tom Herbert
On Mon, Jun 29, 2020 at 12:23 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > ICMP messages may include an extension structure after the original > datagram. RFC 4884 standardized this behavior. > > It introduces an explicit original datagram length field in the ICMP > header to delinea

[PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Willem de Bruijn
From: Willem de Bruijn ICMP messages may include an extension structure after the original datagram. RFC 4884 standardized this behavior. It introduces an explicit original datagram length field in the ICMP header to delineate the original datagram from the extension struct. Return this field w