Re: [PATCH net-next] hinic: add support to set and get pause param

2020-05-17 Thread luobin (L)
Will fix. Thanks. On 2020/5/17 4:25, David Miller wrote: From: Luo bin Date: Sat, 16 May 2020 02:00:30 + add support to set pause param with ethtool -A and get pause param with ethtool -a. Also remove set_link_ksettings ops for VF. Signed-off-by: Luo bin Why are you using a semaphore a

Re: [PATCH net-next] hinic: add support to set and get pause param

2020-05-16 Thread David Miller
From: Luo bin Date: Sat, 16 May 2020 02:00:30 + > add support to set pause param with ethtool -A and get pause > param with ethtool -a. Also remove set_link_ksettings ops for VF. > > Signed-off-by: Luo bin Why are you using a semaphore and not a plain mutex. Semaphores should be used as a

Re: [PATCH net-next] hinic: add support to set and get pause param

2020-05-16 Thread Andrew Lunn
On Sat, May 16, 2020 at 02:00:30AM +, Luo bin wrote: > +static int hinic_set_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pause) > +{ > + struct hinic_dev *nic_dev = netdev_priv(netdev); > + struct hinic_pause_config pause_info = {0};

[PATCH net-next] hinic: add support to set and get pause param

2020-05-16 Thread Luo bin
add support to set pause param with ethtool -A and get pause param with ethtool -a. Also remove set_link_ksettings ops for VF. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 100 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + .../net/etherne