Re: [PATCH net-next] fou: Support binding FoU socket

2019-03-26 Thread David Miller
From: Kristian Evensen Date: Sun, 24 Mar 2019 10:24:55 +0100 > Perhaps there is something I am misunderstanding, or a case I am not aware > of? Ok if all of your tests pass then my concerns are addressed. Please deal with the kbuild robot reported build failures and resubmit, thanks.

Re: [PATCH net-next] fou: Support binding FoU socket

2019-03-24 Thread Kristian Evensen
Hi, On Thu, Mar 21, 2019 at 9:10 PM David Miller wrote: > This seems to allow adding both a wildcarded and a non-wildcarded fou > socket, which otherwise has overlapping match scenerios. > > I don't think you want to allow that unless you can determine that > you aren't creating a situation where

Re: [PATCH net-next] fou: Support binding FoU socket

2019-03-21 Thread kbuild test robot
Hi Kristian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Kristian-Evensen/fou-Support-binding-FoU-socket/20190321-232759 config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.3.0-1)

Re: [PATCH net-next] fou: Support binding FoU socket

2019-03-21 Thread David Miller
From: Kristian Evensen Date: Wed, 20 Mar 2019 09:25:28 +0100 > The lookups performed when we add, delete or get an FoU-socket has also > been updated to compare all the attributes a user can set. Since the > comparison now involves several elements, I have added a separate > comparison-function i

[PATCH net-next] fou: Support binding FoU socket

2019-03-20 Thread Kristian Evensen
An FoU socket is currently bound to the wildcard-address. While this works fine, there are several use-cases where the use of the wildcard-address is not desirable. For example, I use FoU on some multi-homed servers and would like to use FoU on only one of the interfaces. This commit adds support