Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-30 Thread David Miller
From: Tom Herbert Date: Wed, 29 Jul 2015 13:49:03 -0700 > The intent of this function was to produce a consistent hash for both > directions of a flow. However, since we added more inputs to the flow > hashing (IPv6 flow labels for instance) in a lot of cases we won't get > the same hash computed

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 3:15 PM, Eric Dumazet wrote: > On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: > >> Hi Eric, >> >> So the scenario you're thinking is conntrack in the forwarding path, >> RPS enabled (RSS not relevant), no hash from device, no IPv6 flow >> labels or any other asymmetr

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: > Hi Eric, > > So the scenario you're thinking is conntrack in the forwarding path, > RPS enabled (RSS not relevant), no hash from device, no IPv6 flow > labels or any other asymmetric inputs into the flow hash? I can look > at that, but it do

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 2:19 PM, Eric Dumazet wrote: > On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: >> The intent of this function was to produce a consistent hash for both >> directions of a flow. However, since we added more inputs to the flow >> hashing (IPv6 flow labels for instance)

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: > The intent of this function was to produce a consistent hash for both > directions of a flow. However, since we added more inputs to the flow > hashing (IPv6 flow labels for instance) in a lot of cases we won't get > the same hash computed for

[PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
The intent of this function was to produce a consistent hash for both directions of a flow. However, since we added more inputs to the flow hashing (IPv6 flow labels for instance) in a lot of cases we won't get the same hash computed for each direction anyway. Also, there is no defined correlation