Re: [PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread David Miller
From: Tom Herbert Date: Tue, 1 Sep 2015 18:11:04 -0700 > Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash > based on flowi") introduced a bug in __skb_set_sw_hash where we > require a dependency on evaluating arguments in a function in order. > There is no such ordering enfo

Re: [PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread Joe Perches
On Tue, 2015-09-01 at 18:11 -0700, Tom Herbert wrote: > Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash > based on flowi") introduced a bug in __skb_set_sw_hash where we > require a dependency on evaluating arguments in a function in order. > There is no such ordering enforce

[PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread Tom Herbert
Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash based on flowi") introduced a bug in __skb_set_sw_hash where we require a dependency on evaluating arguments in a function in order. There is no such ordering enforced in C, so this incorrect. This patch fixes that by splitting