Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-17 Thread Willem de Bruijn
On Mon, Aug 17, 2020 at 4:44 PM Tom Herbert wrote: > > On Wed, Aug 5, 2020 at 1:27 AM Willem de Bruijn > wrote: > > > > On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote: > > > > > > The definition for symmetric keys does not include the flow label so > > > that when symmetric keys is used a non-

Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-17 Thread Tom Herbert
On Wed, Aug 5, 2020 at 1:27 AM Willem de Bruijn wrote: > > On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote: > > > > The definition for symmetric keys does not include the flow label so > > that when symmetric keys is used a non-zero IPv6 flow label is not > > extracted. Symmetric keys are used i

Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-05 Thread Willem de Bruijn
On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote: > > The definition for symmetric keys does not include the flow label so > that when symmetric keys is used a non-zero IPv6 flow label is not > extracted. Symmetric keys are used in functions to compute the flow > hash for packets, and these functi

Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-04 Thread David Miller
Kernel patch submissions must have proper signoffs.

[PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-04 Thread Tom Herbert
The definition for symmetric keys does not include the flow label so that when symmetric keys is used a non-zero IPv6 flow label is not extracted. Symmetric keys are used in functions to compute the flow hash for packets, and these functions also set "stop at flow label". The upshot is that for IPv