Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-14 Thread David Miller
From: Ben Hutchings Date: Sun, 12 Jun 2016 13:34:12 +0100 > On Sat, 2016-06-11 at 19:26 -0700, David Miller wrote: >> From: Vidya Sagar Ravipati >> Date: Sat, 11 Jun 2016 16:22:38 -0700 >> >> > As part of ethtool application, application is requesting  the drivers >> > to provide the supported

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-12 Thread Ben Hutchings
On Sat, 2016-06-11 at 19:26 -0700, David Miller wrote: > From: Vidya Sagar Ravipati > Date: Sat, 11 Jun 2016 16:22:38 -0700 > > > As part of ethtool application, application is requesting  the drivers > > to provide the supported eeprom size to allocate memory buffer for > > getting complete dump

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-12 Thread Ben Hutchings
On Sat, 2016-06-11 at 15:51 -0700, David Miller wrote: [...] > Why do we need these values in the header file at all? Because we don't like putting magic numbers in driver code, and these sizes are defined by standards that are independent of a single driver. > The application can probe the size

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread David Miller
From: Vidya Sagar Ravipati Date: Sat, 11 Jun 2016 16:22:38 -0700 > As part of ethtool application, application is requesting the drivers > to provide the supported eeprom size to allocate memory buffer for > getting complete dump. And the right way to do that is the driver requests the eeprom i

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread Vidya Sagar Ravipati
On Sat, Jun 11, 2016 at 3:51 PM, David Miller wrote: > From: vi...@cumulusnetworks.com > Date: Mon, 6 Jun 2016 22:55:26 -0700 > >> From: Vidya Sagar Ravipati >> >> This patch provides macro definitions for maximum possible >> memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 >> >>

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread David Miller
From: vi...@cumulusnetworks.com Date: Mon, 6 Jun 2016 22:55:26 -0700 > From: Vidya Sagar Ravipati > > This patch provides macro definitions for maximum possible > memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 > > According to SFF-8436/SFF-8636 specs, the common memory map fo

[PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-06 Thread vidya
From: Vidya Sagar Ravipati This patch provides macro definitions for maximum possible memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 According to SFF-8436/SFF-8636 specs, the common memory map for managing external cable interfaces is arranged into a single lower page address s