On 21/07/2020 20:48, Jakub Kicinski wrote:
> #define TUNNEL_ENCAP_UDP_PORT_ENTRY_INVALID 0x
> Can I add that in mcdi_pcol.h or better next to struct efx_udp_tunnel?
>
> mcdi_pcol.h looks generated.
It is generated, yeah.
So best add it with struct efx_udp_tunnel.
-ed
On Tue, 21 Jul 2020 13:05:39 +0100 Edward Cree wrote:
> On 20/07/2020 18:21, Jakub Kicinski wrote:
> > On Mon, 20 Jul 2020 12:45:54 +0100 Edward Cree wrote:
> >> I think I'd prefer to keep the switch() that explicitlychecks
> >> for UDP_TUNNEL_TYPE_GENEVE; even though the infrastructure
> >> ma
On 20/07/2020 18:21, Jakub Kicinski wrote:
> On Mon, 20 Jul 2020 12:45:54 +0100 Edward Cree wrote:
>> I think I'd prefer to keep the switch() that explicitlychecks
>> for UDP_TUNNEL_TYPE_GENEVE; even though the infrastructure
>> makes sure it won't ever not be, I'd still feel more comfortable
>>
On Mon, 20 Jul 2020 12:45:54 +0100 Edward Cree wrote:
> Subject line prefix should probably be sfc:, that's what we
> usually use for this driver.
Ack.
> On 18/07/2020 00:53, Jakub Kicinski wrote:
> > Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
> > the info, which will hopefully
Subject line prefix should probably be sfc:, that's what we
usually use for this driver.
On 18/07/2020 00:53, Jakub Kicinski wrote:
> Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
> the info, which will hopefully protect us from -EPERM errors
Sorry, I forgot to pass on the answer I
From: Jakub Kicinski
Date: Fri, 17 Jul 2020 16:53:36 -0700
> Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
> the info, which will hopefully protect us from -EPERM errors
> the previous code was gracefully ignoring. Shared code reports
> the port information back to user space, so w
Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
the info, which will hopefully protect us from -EPERM errors
the previous code was gracefully ignoring. Shared code reports
the port information back to user space, so we really want
to know what was added and what failed.
The driver doe
