Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-08 Thread Izabela Bakollari
Hi Eric, Thank you for reviewing my patch. I understand your comments and will be working on correcting what you pointed out. Best, Izabela On Tue, Jul 7, 2020 at 7:52 PM Eric Dumazet wrote: > > > > On 7/7/20 10:15 AM, izabela.bakoll...@gmail.com wrote: > > From: Izabela Bakollari > > > > Dro

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806 base: https://git.kernel.org/pub/scm/linux/kernel/git/d

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806 base: https://git.kernel.org/pub/scm/linux/kernel/git/d

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread Eric Dumazet
On 7/7/20 10:15 AM, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools like tcpdump.

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread Eric Dumazet
On 7/7/20 10:33 AM, Eric Dumazet wrote: > > > What happens after this monitoring is started, then the admin does : > > rmmod ifb > I meant : rmmod dummy

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread Eric Dumazet
On 7/7/20 10:15 AM, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools like tcpdump.

[PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread izabela . bakollari
From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump. With this feature, dropwatch allows two additional commands (start