Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-04 Thread Rahul Lakkireddy
On Monday, August 08/03/20, 2020 at 14:13:04 -0700, Jakub Kicinski wrote: > On Sun, 2 Aug 2020 22:42:28 +0530 Rahul Lakkireddy wrote: > > The config file contains very low-level firmware and device specific > > params and most of them are dependent on the type of Chelsio NIC. > > The params are mos

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-03 Thread Jakub Kicinski
On Sun, 2 Aug 2020 22:42:28 +0530 Rahul Lakkireddy wrote: > The config file contains very low-level firmware and device specific > params and most of them are dependent on the type of Chelsio NIC. > The params are mostly device dependent register-value pairs. > We don't see users messing around wit

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-02 Thread Rahul Lakkireddy
On Saturday, August 08/01/20, 2020 at 21:22:02 -0700, Jakub Kicinski wrote: > On Sat, 1 Aug 2020 02:47:38 +0530 Rahul Lakkireddy wrote: > > I thought /lib/firmware is where firmware related files need to be > > placed and ethtool --flash needs to be used to program them to > > their respective loca

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-01 Thread Jakub Kicinski
On Sat, 1 Aug 2020 02:47:38 +0530 Rahul Lakkireddy wrote: > I thought /lib/firmware is where firmware related files need to be > placed and ethtool --flash needs to be used to program them to > their respective locations on adapter's flash. Our goal is to provide solid, common interfaces for Linux

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-31 Thread Rahul Lakkireddy
On Friday, July 07/31/20, 2020 at 11:00:08 -0700, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 16:39:04 +0530 Ganji Aravind wrote: > > On Thursday, July 07/30/20, 2020 at 16:23:35 -0700, Jakub Kicinski wrote: > > > On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > > > > Update set_flash to

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-31 Thread Jakub Kicinski
On Fri, 31 Jul 2020 16:39:04 +0530 Ganji Aravind wrote: > On Thursday, July 07/30/20, 2020 at 16:23:35 -0700, Jakub Kicinski wrote: > > On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > > > Update set_flash to flash firmware configuration image > > > to flash region. > > > > And the re

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-31 Thread Ganji Aravind
On Thursday, July 07/30/20, 2020 at 16:23:35 -0700, Jakub Kicinski wrote: > On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > > Update set_flash to flash firmware configuration image > > to flash region. > > And the reason why you need to flash some .ini files separately is? Hi Jakub, Th

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-30 Thread Jakub Kicinski
On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > Update set_flash to flash firmware configuration image > to flash region. And the reason why you need to flash some .ini files separately is?

[PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-30 Thread Ganji Aravind
Update set_flash to flash firmware configuration image to flash region. Signed-off-by: Ganji Aravind --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +- .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c| 93 +++ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c| 13 ++- 3 files