Re: [PATCH net-next] checkpatch: warn about uses of ENOTSUPP

2020-05-11 Thread Jakub Kicinski
On Sun, 10 May 2020 12:56:53 -0700 Joe Perches wrote: > On Sun, 2020-05-10 at 11:51 -0700, Jakub Kicinski wrote: > > Hi Joe, I feel like I already talked to you about this, but I lost > > my email archive, so appologies if you already said no. > > Not so far as I can tell. > > This seems OK to

Re: [PATCH net-next] checkpatch: warn about uses of ENOTSUPP

2020-05-10 Thread Joe Perches
On Sun, 2020-05-10 at 11:51 -0700, Jakub Kicinski wrote: > ENOTSUPP often feels like the right error code to use, but it's > in fact not a standard Unix error. E.g.: It is SUSv3 though. > $ python > > > > import errno > > > > errno.errorcode[errno.ENOTSUPP] > Traceback (most recent call last): >

Re: [PATCH net-next] checkpatch: warn about uses of ENOTSUPP

2020-05-10 Thread Jakub Kicinski
On Sun, 10 May 2020 21:04:32 +0200 Andrew Lunn wrote: > On Sun, May 10, 2020 at 11:51:48AM -0700, Jakub Kicinski wrote: > > ENOTSUPP often feels like the right error code to use, but it's > > in fact not a standard Unix error. E.g.: > > Hi Jakub > > You said ENOTSUPP is for NFS? Would it make s

Re: [PATCH net-next] checkpatch: warn about uses of ENOTSUPP

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 11:51:48AM -0700, Jakub Kicinski wrote: > ENOTSUPP often feels like the right error code to use, but it's > in fact not a standard Unix error. E.g.: Hi Jakub You said ENOTSUPP is for NFS? Would it make sense to special case fs/nfs* files and not warn there? I assume that w

[PATCH net-next] checkpatch: warn about uses of ENOTSUPP

2020-05-10 Thread Jakub Kicinski
ENOTSUPP often feels like the right error code to use, but it's in fact not a standard Unix error. E.g.: $ python >>> import errno >>> errno.errorcode[errno.ENOTSUPP] Traceback (most recent call last): File "", line 1, in AttributeError: module 'errno' has no attribute 'ENOTSUPP' There were nu