Re: [PATCH net-next] bridge: multicast: disable port when in blocking state

2015-06-23 Thread Nikolay Aleksandrov
> On Jun 23, 2015, at 2:52 AM, Herbert Xu wrote: > > On Mon, Jun 22, 2015 at 11:38:36PM +0300, Nikolay Aleksandrov wrote: >> >> One more thing - I don’t think we need any additional changes because >> there’s a check in >> br_multicast_port_query_expired(): >> if (port->state == BR_STATE_

Re: [PATCH net-next] bridge: multicast: disable port when in blocking state

2015-06-22 Thread Herbert Xu
On Mon, Jun 22, 2015 at 11:38:36PM +0300, Nikolay Aleksandrov wrote: > > One more thing - I don’t think we need any additional changes because there’s > a check in > br_multicast_port_query_expired(): > if (port->state == BR_STATE_DISABLED || > port->state == BR_STATE_BLOCKING)

Re: [PATCH net-next] bridge: multicast: disable port when in blocking state

2015-06-22 Thread Nikolay Aleksandrov
> On Jun 22, 2015, at 11:25 PM, Nikolay Aleksandrov > wrote: > > >> On Jun 22, 2015, at 11:12 PM, Nikolay Aleksandrov >> wrote: >> >> Currently when a port goes in blocking state the multicast is not >> disabled. Fix it by disabling a port if its state has transitioned to >> blocking, this

Re: [PATCH net-next] bridge: multicast: disable port when in blocking state

2015-06-22 Thread Nikolay Aleksandrov
> On Jun 22, 2015, at 11:12 PM, Nikolay Aleksandrov > wrote: > > Currently when a port goes in blocking state the multicast is not > disabled. Fix it by disabling a port if its state has transitioned to > blocking, this has effect for both user- and kernel-space stp. > > Reported-by: Herbert X

[PATCH net-next] bridge: multicast: disable port when in blocking state

2015-06-22 Thread Nikolay Aleksandrov
Currently when a port goes in blocking state the multicast is not disabled. Fix it by disabling a port if its state has transitioned to blocking, this has effect for both user- and kernel-space stp. Reported-by: Herbert Xu Signed-off-by: Nikolay Aleksandrov --- note: this is on top of patch: "br