Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-29 Thread David Ahern
On 8/29/17 12:46 AM, Bhumika Goyal wrote: > I am compile testing them. In this case I did: make > net/ipv4/af_inet.o and it compiled. Is this error because of > typecasting net_protocol inside inet_add_protocol function? Compile testing is not sufficient. Marking data structures read-only leaves

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2017 12:16:23 +0530 Bhumika Goyal wrote: > On Tue, Aug 29, 2017 at 1:53 AM, David Ahern wrote: > > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > > > > Early demux structs can not be made const. Doing so results in: > > [ 84.967355] BUG: unable to handle kernel

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread Bhumika Goyal
On Tue, Aug 29, 2017 at 1:53 AM, David Ahern wrote: > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > > Early demux structs can not be made const. Doing so results in: > [ 84.967355] BUG: unable to handle kernel paging request at 81684b10 > [ 84.969272] IP: proc_configu

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 15:03:34 -0600 > On 8/28/17 3:01 PM, David Miller wrote: >> From: David Ahern >> Date: Mon, 28 Aug 2017 13:23:09 -0700 >> >>> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. >> ... >>> I think this is the second time such a patch has been r

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread Stephen Hemminger
On Mon, 28 Aug 2017 13:23:09 -0700 David Ahern wrote: > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > > Early demux structs can not be made const. Doing so results in: > [ 84.967355] BUG: unable to handle kernel paging request at 81684b10 > [ 84.969272] IP: proc_con

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Ahern
On 8/28/17 3:01 PM, David Miller wrote: > From: David Ahern > Date: Mon, 28 Aug 2017 13:23:09 -0700 > >> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > ... >> I think this is the second time such a patch has been reverted. > > Then please add a comment, it will help prevent this

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 13:23:09 -0700 > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. ... > I think this is the second time such a patch has been reverted. Then please add a comment, it will help prevent this from happening again.

[PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Ahern
This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. Early demux structs can not be made const. Doing so results in: [ 84.967355] BUG: unable to handle kernel paging request at 81684b10 [ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d [ 84.970544] PGD 1a0a067 [ 84.970