Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-08-16 Thread Edward Cree
On 16/08/2019 02:04, Pablo Neira Ayuso wrote: > On Wed, Aug 14, 2019 at 05:17:20PM +0100, Edward Cree wrote: >> TBH I'm still not clear why you need a flow_block per subsystem, rather than >>  just having multiple subsystems feed their offload requests through the same >>  flow_block but with diffe

Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-08-15 Thread Pablo Neira Ayuso
On Wed, Aug 14, 2019 at 05:17:20PM +0100, Edward Cree wrote: > On 13/08/2019 20:51, Pablo Neira Ayuso wrote: > > On Mon, Aug 12, 2019 at 06:50:09PM +0100, Edward Cree wrote: > >> Pablo, can you explain (because this commit message doesn't) why these per- > >>  driver lists are needed, and what the

Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-08-14 Thread Edward Cree
On 13/08/2019 20:51, Pablo Neira Ayuso wrote: > On Mon, Aug 12, 2019 at 06:50:09PM +0100, Edward Cree wrote: >> Pablo, can you explain (because this commit message doesn't) why these per- >>  driver lists are needed, and what the information/state is that has module >>  (rather than, say, netdevice

Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-08-13 Thread Pablo Neira Ayuso
On Mon, Aug 12, 2019 at 06:50:09PM +0100, Edward Cree wrote: > On 09/07/2019 21:55, Pablo Neira Ayuso wrote: > > This patch updates flow_block_cb_setup_simple() to use the flow block API. > > Several drivers are also adjusted to use it. > > > > This patch introduces the per-driver list of flow bloc

Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-08-12 Thread Edward Cree
On 09/07/2019 21:55, Pablo Neira Ayuso wrote: > This patch updates flow_block_cb_setup_simple() to use the flow block API. > Several drivers are also adjusted to use it. > > This patch introduces the per-driver list of flow blocks to account for > blocks that are already in use. > > Remove tc_block

Re: [PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-07-10 Thread Jiri Pirko
Tue, Jul 09, 2019 at 10:55:46PM CEST, pa...@netfilter.org wrote: [...] > static int > mlxsw_sp_setup_tc_block_flower_bind(struct mlxsw_sp_port *mlxsw_sp_port, >- struct tcf_block *block, bool ingress, >- struct netlink_e

[PATCH net-next,v4 08/12] drivers: net: use flow block API

2019-07-09 Thread Pablo Neira Ayuso
This patch updates flow_block_cb_setup_simple() to use the flow block API. Several drivers are also adjusted to use it. This patch introduces the per-driver list of flow blocks to account for blocks that are already in use. Remove tc_block_offload alias. Signed-off-by: Pablo Neira Ayuso --- v4: