Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-20 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 18:15:20 +0100 > Pavel Emelyanov a écrit : > > That's not truth, if I get you right. The __inet_hash() is called > > with 0, from all the places except for the inet_hash() one. > > OK, but on cases with 0, sk->sk_state is != TCP_LISTEN

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Eric Dumazet
Pavel Emelyanov a écrit : Eric Dumazet wrote: Pavel Emelyanov a écrit : Eric Dumazet wrote: If you un-inline this (good idea), I am not sure we still need listen_possible argument. It was usefull only to help compiler to zap dead code (since it was known at compile time), now it only adds s

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Pavel Emelyanov
Eric Dumazet wrote: > Pavel Emelyanov a écrit : >> Eric Dumazet wrote: >>> Pavel Emelyanov a écrit : This one is used in quite many places in the networking code and seems to big to be inline. After the patch net/ipv4/build-in.o loses 725 bytes: add/remove: 1/0 grow/shrink:

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Eric Dumazet
Pavel Emelyanov a écrit : Eric Dumazet wrote: Pavel Emelyanov a écrit : This one is used in quite many places in the networking code and seems to big to be inline. After the patch net/ipv4/build-in.o loses 725 bytes: add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725) function

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Pavel Emelyanov
Eric Dumazet wrote: > Pavel Emelyanov a écrit : >> This one is used in quite many places in the networking code and >> seems to big to be inline. >> >> After the patch net/ipv4/build-in.o loses 725 bytes: >> add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725) >> function

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Eric Dumazet
Pavel Emelyanov a écrit : This one is used in quite many places in the networking code and seems to big to be inline. After the patch net/ipv4/build-in.o loses 725 bytes: add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725) function old new delta _

[PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-19 Thread Pavel Emelyanov
This one is used in quite many places in the networking code and seems to big to be inline. After the patch net/ipv4/build-in.o loses 725 bytes: add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725) function old new delta __inet_hash