Re: [PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-19 Thread Steffen Klassert
On Sun, Sep 18, 2016 at 07:42:53AM +, Ilan Tayari wrote: > commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") > introduced aead. The function attach_aead kmemdup()s the algorithm > name during xfrm_state_construct(). > However this memory is never freed. > Implementation

Re: [PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-18 Thread Rami Rosen
Acked-by: Rami Rosen On 18 September 2016 at 10:42, Ilan Tayari wrote: > commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") > introduced aead. The function attach_aead kmemdup()s the algorithm > name during xfrm_state_construct(). > However this memory is never freed. > Im

[PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-18 Thread Ilan Tayari
commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") introduced aead. The function attach_aead kmemdup()s the algorithm name during xfrm_state_construct(). However this memory is never freed. Implementation has since been slightly modified in commit ee5c23176fcc ("xfrm: Clone s