Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Wei Liu
On Mon, Jun 01, 2015 at 09:52:45AM +0100, Ian Campbell wrote: > On Fri, 2015-05-29 at 18:38 +0100, Wei Liu wrote: > > On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: > > [...] > > > if (be->vif != NULL) > > > return 0; > > > @@ -417,12 +409,23 @@ static int backend_create_

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Ian Campbell
On Fri, 2015-05-29 at 18:38 +0100, Wei Liu wrote: > On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: > [...] > > if (be->vif != NULL) > > return 0; > > @@ -417,12 +409,23 @@ static int backend_create_xenvif(struct backend_info > > *be) > > return (err < 0)

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread Wei Liu
On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: [...] > if (be->vif != NULL) > return 0; > @@ -417,12 +409,23 @@ static int backend_create_xenvif(struct backend_info > *be) > return (err < 0) ? err : -EINVAL; > } > > + script = xenbus_rea

[PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread Ian Campbell
When we come to tear things down in netback_remove() and generate the uevent it is possible that the xenstore directory has already been removed (details below). In such cases netback_uevent() won't be able to read the hotplug script and will write a xenstore error node. A recent change to the hy

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread David Vrabel
On 29/05/15 17:24, Ian Campbell wrote: > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev) > kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE); > xen_unregister_watchers(b