Re: [PATCH net] vlan: Propagate MAC address changes properly

2016-05-03 Thread David Miller
From: Mike Manning Date: Tue, 3 May 2016 16:18:42 +0100 > Given that this information is implicit in real_dev_addr That's not the reason to make or not make the simplification I asked you do. You can add a multi-page comment to this code, and the confusing tests are still rediculous. Please ad

Re: [PATCH net] vlan: Propagate MAC address changes properly

2016-05-03 Thread Mike Manning
On 05/03/2016 05:16 AM, David Miller wrote: > From: Mike Manning > Date: Sat, 30 Apr 2016 11:32:37 +0100 > >> The MAC address of the physical interface is only copied to the VLAN >> when it is first created, resulting in an inconsistency after MAC >> address changes of only newly created VLANs ha

Re: [PATCH net] vlan: Propagate MAC address changes properly

2016-05-02 Thread David Miller
From: Mike Manning Date: Sat, 30 Apr 2016 11:32:37 +0100 > The MAC address of the physical interface is only copied to the VLAN > when it is first created, resulting in an inconsistency after MAC > address changes of only newly created VLANs having an up-to-date MAC. > > Continuing to inherit th

[PATCH net] vlan: Propagate MAC address changes properly

2016-04-30 Thread Mike Manning
The MAC address of the physical interface is only copied to the VLAN when it is first created, resulting in an inconsistency after MAC address changes of only newly created VLANs having an up-to-date MAC. Continuing to inherit the MAC address unless explicitly changed for the VLAN allows IPv6 EUI6