Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-07-05 Thread Michael S. Tsirkin
On Tue, Jul 04, 2017 at 08:20:00PM +0800, Jason Wang wrote: > > IIUC XDP generally refuses to attach if checksum offload > > is enabled. > > Any reason to do this? (Looks like I don't see any code for this) Some of it was covered here https://www.mail-archive.com/netdev@vger.kernel.org/msg162577.

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-07-04 Thread Jason Wang
On 2017年07月04日 01:03, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 08:05:06PM +0800, Jason Wang wrote: On 2017年06月28日 12:01, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: On 2017年06月28日 11:31, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-07-03 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 08:05:06PM +0800, Jason Wang wrote: > > > On 2017年06月28日 12:01, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: > > > > > > On 2017年06月28日 11:31, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wa

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-28 Thread Jason Wang
On 2017年06月28日 12:01, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: On 2017年06月28日 11:31, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: On 2017年06月28日 10:17, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: > > > On 2017年06月28日 11:31, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:17, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrot

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 11:31, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: On 2017年06月28日 10:17, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:17, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: > > > > > > On 2017年06月28日 10:02, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wa

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 10:17, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: We should allow csumed packet for small buffer, otherwise XDP_PASS won't wo

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:02, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: > > > We should allow csumed packet for small buffer, otherwise XDP_PASS > > > won't work correctly. > > > > > > Fixes

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: We should allow csumed packet for small buffer, otherwise XDP_PASS won't work correctly. Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") Signed-off-by: Jason Wan

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: > We should allow csumed packet for small buffer, otherwise XDP_PASS > won't work correctly. > > Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") > Signed-off-by: Jason Wang The issue would be VIRTIO_NET_HDR_F_DAT

[PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
We should allow csumed packet for small buffer, otherwise XDP_PASS won't work correctly. Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") Signed-off-by: Jason Wang --- The patch is needed for -stable. --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 d