Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread Michael S. Tsirkin
On Fri, Feb 05, 2021 at 02:28:33PM -0800, Wei Wang wrote: > On Thu, Feb 4, 2021 at 12:48 PM Willem de Bruijn > wrote: > > > > On Wed, Feb 3, 2021 at 6:53 PM Wei Wang wrote: > > > > > > On Wed, Feb 3, 2021 at 3:10 PM Michael S. Tsirkin wrote: > > > > > > > > On Wed, Feb 03, 2021 at 01:24:08PM -05

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread Michael S. Tsirkin
On Mon, Apr 12, 2021 at 04:14:58PM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Mon, 12 Apr 2021 18:33:45 -0400 > > > On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote: > >> OK I started looking at this again. My idea is simple. > >> A. disable callbacks before

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 12 Apr 2021 18:33:45 -0400 > On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote: >> OK I started looking at this again. My idea is simple. >> A. disable callbacks before we try to drain skbs >> B. actually do disable callbacks even with event

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread Michael S. Tsirkin
On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote: > OK I started looking at this again. My idea is simple. > A. disable callbacks before we try to drain skbs > B. actually do disable callbacks even with event idx > > To make B not regress, we need to > C. detect the common case o

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread Michael S. Tsirkin
OK I started looking at this again. My idea is simple. A. disable callbacks before we try to drain skbs B. actually do disable callbacks even with event idx To make B not regress, we need to C. detect the common case of disable after event triggering and skip the write then. I added a new event_

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-21 Thread Michael S. Tsirkin
On Thu, Feb 18, 2021 at 01:39:19PM +0800, Jason Wang wrote: > > On 2021/2/10 下午5:14, Michael S. Tsirkin wrote: > > On Tue, Feb 09, 2021 at 10:00:22AM -0800, Wei Wang wrote: > > > On Tue, Feb 9, 2021 at 6:58 AM Willem de Bruijn > > > wrote: > > > > > > > > I have no preference. Just curious, espec

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-17 Thread Jason Wang
On 2021/2/10 下午5:14, Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 10:00:22AM -0800, Wei Wang wrote: On Tue, Feb 9, 2021 at 6:58 AM Willem de Bruijn wrote: I have no preference. Just curious, especially if it complicates the patch. My understanding is that. It's probably ok for net. Bu

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-10 Thread Michael S. Tsirkin
On Tue, Feb 09, 2021 at 10:00:22AM -0800, Wei Wang wrote: > On Tue, Feb 9, 2021 at 6:58 AM Willem de Bruijn > wrote: > > > > > >>> I have no preference. Just curious, especially if it complicates the > > > >>> patch. > > > >>> > > > >> My understanding is that. It's probably ok for net. But we pr

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-09 Thread Willem de Bruijn
> >>> I have no preference. Just curious, especially if it complicates the > >>> patch. > >>> > >> My understanding is that. It's probably ok for net. But we probably need > >> to document the assumptions to make sure it was not abused in other > >> drivers. > >> > >> Introduce new parameters for

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:08, Willem de Bruijn wrote: On Sun, Feb 7, 2021 at 10:29 PM Jason Wang wrote: On 2021/2/5 上午4:50, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-08 Thread Willem de Bruijn
On Sun, Feb 7, 2021 at 10:29 PM Jason Wang wrote: > > > On 2021/2/5 上午4:50, Willem de Bruijn wrote: > > On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: > >> > >> On 2021/2/4 上午2:28, Willem de Bruijn wrote: > >>> On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: > On 2021/2/2 下午10:37, Will

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-07 Thread Jason Wang
On 2021/2/5 上午4:50, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-04 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: > > > On 2021/2/4 上午2:28, Willem de Bruijn wrote: > > On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: > >> > >> On 2021/2/2 下午10:37, Willem de Bruijn wrote: > >>> On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: > On 2021/1/29 上午8:21, Wei

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-04 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 6:53 PM Wei Wang wrote: > > On Wed, Feb 3, 2021 at 3:10 PM Michael S. Tsirkin wrote: > > > > On Wed, Feb 03, 2021 at 01:24:08PM -0500, Willem de Bruijn wrote: > > > On Wed, Feb 3, 2021 at 5:42 AM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Feb 02, 2021 at 07:06:53PM

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Jason Wang
On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Michael S. Tsirkin
On Wed, Feb 03, 2021 at 01:24:08PM -0500, Willem de Bruijn wrote: > On Wed, Feb 3, 2021 at 5:42 AM Michael S. Tsirkin wrote: > > > > On Tue, Feb 02, 2021 at 07:06:53PM -0500, Willem de Bruijn wrote: > > > On Tue, Feb 2, 2021 at 6:53 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Feb 2,

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: > > > On 2021/2/2 下午10:37, Willem de Bruijn wrote: > > On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: > >> > >> On 2021/1/29 上午8:21, Wei Wang wrote: > >>> With the implementation of napi-tx in virtio driver, we clean tx > >>> descriptors from r

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 5:42 AM Michael S. Tsirkin wrote: > > On Tue, Feb 02, 2021 at 07:06:53PM -0500, Willem de Bruijn wrote: > > On Tue, Feb 2, 2021 at 6:53 PM Willem de Bruijn wrote: > > > > > > On Tue, Feb 2, 2021 at 6:47 PM Wei Wang wrote: > > > > > > > > On Tue, Feb 2, 2021 at 3:12 PM Mich

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Michael S. Tsirkin
On Tue, Feb 02, 2021 at 07:06:53PM -0500, Willem de Bruijn wrote: > On Tue, Feb 2, 2021 at 6:53 PM Willem de Bruijn wrote: > > > > On Tue, Feb 2, 2021 at 6:47 PM Wei Wang wrote: > > > > > > On Tue, Feb 2, 2021 at 3:12 PM Michael S. Tsirkin wrote: > > > > > > > > On Thu, Jan 28, 2021 at 04:21:36P

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-02 Thread Jason Wang
On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But this

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-02 Thread Michael S. Tsirkin
On Thu, Jan 28, 2021 at 04:21:36PM -0800, Wei Wang wrote: > With the implementation of napi-tx in virtio driver, we clean tx > descriptors from rx napi handler, for the purpose of reducing tx > complete interrupts. But this could introduce a race where tx complete > interrupt has been raised, but t

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-02 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: > > > On 2021/1/29 上午8:21, Wei Wang wrote: > > With the implementation of napi-tx in virtio driver, we clean tx > > descriptors from rx napi handler, for the purpose of reducing tx > > complete interrupts. But this could introduce a race where tx c

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-01 Thread Jason Wang
On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But this could introduce a race where tx complete interrupt has been raised, but the handler found there is

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-01 Thread Jakub Kicinski
On Thu, 28 Jan 2021 16:21:36 -0800 Wei Wang wrote: > With the implementation of napi-tx in virtio driver, we clean tx > descriptors from rx napi handler, for the purpose of reducing tx > complete interrupts. But this could introduce a race where tx complete > interrupt has been raised, but the hand