Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-30 Thread Jakub Kicinski
On Wed, 30 Apr 2025 01:29:06 -0400 Michael S. Tsirkin wrote: > > > @@ -3728,7 +3731,7 @@ static int virtnet_set_queues(struct virtnet_info > > > *vi, u16 queue_pairs) > > > succ: > > > vi->curr_queue_pairs = queue_pairs; > > > /* virtnet_open() will refill when device is going to

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-29 Thread Michael S. Tsirkin
On Wed, Apr 30, 2025 at 11:49:15AM +0800, Jason Wang wrote: > On Tue, Apr 29, 2025 at 10:31 PM Jakub Kicinski wrote: > > > > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > > fixed a deadlock between reconfig paths and refill work trying to disable > > the same NAPI in

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-29 Thread Michael S. Tsirkin
On Tue, Apr 29, 2025 at 07:31:04AM -0700, Jakub Kicinski wrote: > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > fixed a deadlock between reconfig paths and refill work trying to disable > the same NAPI instance. The refill work can't run in parallel with reconfig > be

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-29 Thread Jason Wang
On Tue, Apr 29, 2025 at 10:31 PM Jakub Kicinski wrote: > > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > fixed a deadlock between reconfig paths and refill work trying to disable > the same NAPI instance. The refill work can't run in parallel with reconfig > because

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-29 Thread Bui Quang Minh
On 4/29/25 21:31, Jakub Kicinski wrote: Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") fixed a deadlock between reconfig paths and refill work trying to disable the same NAPI instance. The refill work can't run in parallel with reconfig because trying to double-disable

[PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-29 Thread Jakub Kicinski
Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") fixed a deadlock between reconfig paths and refill work trying to disable the same NAPI instance. The refill work can't run in parallel with reconfig because trying to double-disable a NAPI instance causes a stall under the