Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Ben Greear
On 02/28/2018 09:22 AM, David Miller wrote: From: Jason Wang Date: Wed, 28 Feb 2018 18:20:04 +0800 We try to disable NAPI to prevent a single XDP TX queue being used by multiple cpus. But we don't check if device is up (NAPI is enabled), this could result stall because of infinite wait in napi

Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread David Miller
From: Jason Wang Date: Wed, 28 Feb 2018 18:20:04 +0800 > We try to disable NAPI to prevent a single XDP TX queue being used by > multiple cpus. But we don't check if device is up (NAPI is enabled), > this could result stall because of infinite wait in > napi_disable(). Fixing this by checking dev

Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Michael S. Tsirkin
On Wed, Feb 28, 2018 at 06:20:04PM +0800, Jason Wang wrote: > We try to disable NAPI to prevent a single XDP TX queue being used by > multiple cpus. But we don't check if device is up (NAPI is enabled), > this could result stall because of infinite wait in > napi_disable(). Fixing this by checking

[PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Jason Wang
We try to disable NAPI to prevent a single XDP TX queue being used by multiple cpus. But we don't check if device is up (NAPI is enabled), this could result stall because of infinite wait in napi_disable(). Fixing this by checking device state through netif_running() before. Fixes: 4941d472bf95b (