Re: [PATCH net] udp: consistently apply ufo or fragmentation

2017-08-14 Thread Willem de Bruijn
> ip*_ufo_append_data() is called now for each skb_is_gso() packet. > Before the patch it was called for UDP packets only. > > Could you please clarify, is it correct? __ip_append_data is called for udp, raw, icmp and ping sockets. Of these, only udp packets have a path to get skb_is_gso() set: wh

[PATCH net] udp: consistently apply ufo or fragmentation

2017-08-14 Thread Vasily Averin
Dear Willem, ip*_ufo_append_data() is called now for each skb_is_gso() packet. Before the patch it was called for UDP packets only. Could you please clarify, is it correct? Thank you, Vasily Averin

Re: [PATCH net] udp: consistently apply ufo or fragmentation

2017-08-10 Thread David Miller
From: Willem de Bruijn Date: Thu, 10 Aug 2017 12:29:19 -0400 > From: Willem de Bruijn > > When iteratively building a UDP datagram with MSG_MORE and that > datagram exceeds MTU, consistently choose UFO or fragmentation. > > Once skb_is_gso, always apply ufo. Conversely, once a datagram is > sp

[PATCH net] udp: consistently apply ufo or fragmentation

2017-08-10 Thread Willem de Bruijn
From: Willem de Bruijn When iteratively building a UDP datagram with MSG_MORE and that datagram exceeds MTU, consistently choose UFO or fragmentation. Once skb_is_gso, always apply ufo. Conversely, once a datagram is split across multiple skbs, do not consider ufo. Sendpage already maintains th