Re: [PATCH net] tls: fix NULL pointer dereference on poll

2018-06-12 Thread Daniel Borkmann
On 06/12/2018 07:37 AM, Christoph Hellwig wrote: >> Looks like the recent conversion from poll to poll_mask callback started >> in 152524231023 ("net: add support for ->poll_mask in proto_ops") missed >> to eventually convert kTLS, too: TCP's ->poll was converted over to the >> ->poll_mask in commi

Re: [PATCH net] tls: fix NULL pointer dereference on poll

2018-06-11 Thread Christoph Hellwig
> Looks like the recent conversion from poll to poll_mask callback started > in 152524231023 ("net: add support for ->poll_mask in proto_ops") missed > to eventually convert kTLS, too: TCP's ->poll was converted over to the > ->poll_mask in commit 2c7d3dacebd4 ("net/tcp: convert to ->poll_mask") >

Re: [PATCH net] tls: fix NULL pointer dereference on poll

2018-06-11 Thread David Miller
From: Daniel Borkmann Date: Mon, 11 Jun 2018 23:22:04 +0200 > While hacking on kTLS, I ran into the following panic from an > unprivileged netserver / netperf TCP session: ... > Debugging further, it turns out that calling into ctx->sk_poll() is > invalid since sk_poll itself is NULL which was s

Re: [PATCH net] tls: fix NULL pointer dereference on poll

2018-06-11 Thread Dave Watson
On 06/11/18 11:22 PM, Daniel Borkmann wrote: > While hacking on kTLS, I ran into the following panic from an > unprivileged netserver / netperf TCP session: > > [...] > Looks like the recent conversion from poll to poll_mask callback started > in 152524231023 ("net: add support for ->poll_mask i

[PATCH net] tls: fix NULL pointer dereference on poll

2018-06-11 Thread Daniel Borkmann
While hacking on kTLS, I ran into the following panic from an unprivileged netserver / netperf TCP session: BUG: unable to handle kernel NULL pointer dereference at PGD 80037f378067 P4D 80037f378067 PUD 3c0e61067 PMD 0 Oops: 0010 [#1] SMP KASAN PTI CPU: 1 PID: 2289