Re: [PATCH net] tls: don't use stack memory in a scatterlist

2018-05-17 Thread David Miller
From: Matt Mullins Date: Thu, 17 May 2018 20:28:46 + > On Thu, 2018-05-17 at 14:50 -0400, David Miller wrote: >> I'm surprised this problem wasn't discovered sooner. How exactly did you >> discover it? Did you actually see it trigger or is this purely from code >> inspection? > > Honestly,

Re: [PATCH net] tls: don't use stack memory in a scatterlist

2018-05-17 Thread Matt Mullins
On Thu, 2018-05-17 at 14:50 -0400, David Miller wrote: > I'm surprised this problem wasn't discovered sooner. How exactly did you > discover it? Did you actually see it trigger or is this purely from code > inspection? Honestly, I'm not sure how it got uncovered, but it was observed at runtime.

Re: [PATCH net] tls: don't use stack memory in a scatterlist

2018-05-17 Thread David Miller
From: Matt Mullins Date: Wed, 16 May 2018 10:48:40 -0700 > scatterlist code expects virt_to_page() to work, which fails with > CONFIG_VMAP_STACK=y. > > Fixes: c46234ebb4d1e ("tls: RX path for ktls") > Signed-off-by: Matt Mullins Applied and queued up for -stable, thanks. I'm surprised this pr

[PATCH net] tls: don't use stack memory in a scatterlist

2018-05-16 Thread Matt Mullins
scatterlist code expects virt_to_page() to work, which fails with CONFIG_VMAP_STACK=y. Fixes: c46234ebb4d1e ("tls: RX path for ktls") Signed-off-by: Matt Mullins --- include/net/tls.h | 3 +++ net/tls/tls_sw.c | 9 - 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include