Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Tetsuo Handa
On Fri, May 22, 2020 at 2:30 AM Eric Dumazet wrote: > dst_cache_get() documents it must be used with BH disabled. Since the report was complaining about preemption at this_cpu_ptr(), and "#syz test" request with my preemption-disable patch no longer complained, I didn't realize that it is docum

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread David Miller
From: Eric Dumazet Date: Thu, 21 May 2020 11:29:58 -0700 > dst_cache_get() documents it must be used with BH disabled. > > sysbot reported : > > BUG: using smp_processor_id() in preemptible [] code: /21697 > caller is dst_cache_get+0x3a/0xb0 net/core/dst_cache.c:68 ... > Fixes: e9c1a79

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Jon Maloy
On 5/22/20 4:10 PM, Eric Dumazet wrote: On 5/22/20 12:47 PM, Jon Maloy wrote: On 5/22/20 11:57 AM, Eric Dumazet wrote: On 5/22/20 8:01 AM, Jon Maloy wrote: On 5/22/20 2:18 AM, Xin Long wrote: On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: Resend to the list in non HTML form On T

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Eric Dumazet
On 5/22/20 12:47 PM, Jon Maloy wrote: > > > On 5/22/20 11:57 AM, Eric Dumazet wrote: >> >> On 5/22/20 8:01 AM, Jon Maloy wrote: >>> >>> On 5/22/20 2:18 AM, Xin Long wrote: On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: > Resend to the list in non HTML form > > > On T

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Jon Maloy
On 5/22/20 11:57 AM, Eric Dumazet wrote: On 5/22/20 8:01 AM, Jon Maloy wrote: On 5/22/20 2:18 AM, Xin Long wrote: On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: Resend to the list in non HTML form On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote: On Thu, May 21, 2020 at 10:5

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Eric Dumazet
On 5/22/20 8:01 AM, Jon Maloy wrote: > > > On 5/22/20 2:18 AM, Xin Long wrote: >> On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: >>> Resend to the list in non HTML form >>> >>> >>> On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote: On Thu, May 21, 2020 at 10:50 PM Xin L

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Eric Dumazet
On 5/21/20 11:18 PM, Xin Long wrote: > On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: >> >> Resend to the list in non HTML form >> >> >> On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote: >>> >>> >>> >>> On Thu, May 21, 2020 at 10:50 PM Xin Long wrote: On Fri, May 22, 2020 at

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Jon Maloy
On 5/22/20 2:18 AM, Xin Long wrote: On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: Resend to the list in non HTML form On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote: On Thu, May 21, 2020 at 10:50 PM Xin Long wrote: On Fri, May 22, 2020 at 2:30 AM Eric Dumazet wrote: dst_

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-21 Thread Xin Long
On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote: > > Resend to the list in non HTML form > > > On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote: > > > > > > > > On Thu, May 21, 2020 at 10:50 PM Xin Long wrote: > >> > >> On Fri, May 22, 2020 at 2:30 AM Eric Dumazet wrote: > >> > > >> > dst

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-21 Thread Xin Long
On Fri, May 22, 2020 at 2:30 AM Eric Dumazet wrote: > > dst_cache_get() documents it must be used with BH disabled. Interesting, I thought under rcu_read_lock() is enough, which calls preempt_disable(). have you checked other places where dst_cache_get() are used? > > sysbot reported : > > BUG: u