Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-09-01 Thread Ivan Vecera
Dne 31.8.2016 v 18:19 Michael Chan napsal(a): On Wed, Aug 31, 2016 at 2:27 AM, Ivan Vecera wrote: Dne 30.8.2016 v 17:46 Michael Chan napsal(a): On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote: The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 as this stops generatin

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-31 Thread Michael Chan
On Wed, Aug 31, 2016 at 2:27 AM, Ivan Vecera wrote: > Dne 30.8.2016 v 17:46 Michael Chan napsal(a): >> >> On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote: >>> >>> The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 >>> as this stops generating interrupts for the incoming pac

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-31 Thread Ivan Vecera
Dne 30.8.2016 v 17:46 Michael Chan napsal(a): On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote: The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 as this stops generating interrupts for the incoming packets. I found the zero Tx coalescing time stops generating interrupts

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-31 Thread Ivan Vecera
Dne 30.8.2016 v 19:52 Sergei Shtylyov napsal(a): Hello. On 08/30/2016 05:38 PM, Ivan Vecera wrote: The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 You should specify both 12-digit SHA1 and the commit summary enclosed in (""). as this stops generating interrupts f

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2016 05:38 PM, Ivan Vecera wrote: The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 You should specify both 12-digit SHA1 and the commit summary enclosed in (""). as this stops generating interrupts for the incoming packets. I found the zero Tx coale

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-30 Thread Michael Chan
On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote: > The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 > as this stops generating interrupts for the incoming packets. I found > the zero Tx coalescing time stops generating interrupts similarly for > outgoing packets and fires

[PATCH net] tg3: Fix for disallow tx coalescing time to be 0

2016-08-30 Thread Ivan Vecera
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 as this stops generating interrupts for the incoming packets. I found the zero Tx coalescing time stops generating interrupts similarly for outgoing packets and fires Tx watchdog later. To avoid this, don't allow to set Tx coale