Re: [PATCH net] tcp: fix slab-out-of-bounds in tcp_zerocopy_receive()

2019-10-03 Thread David Miller
From: Eric Dumazet Date: Wed, 2 Oct 2019 20:19:59 -0700 > Apparently a refactoring patch brought a bug, that was caught > by syzbot [1] > > Original code was correct, do not try to be smarter than the > compiler :/ > > [1] ... > Fixes: d8e18a516f8f ("net: Use skb accessors in network core") >

Re: [PATCH net] tcp: fix slab-out-of-bounds in tcp_zerocopy_receive()

2019-10-03 Thread Eric Dumazet
On 10/3/19 2:46 AM, Matthew Wilcox wrote: > On Wed, Oct 02, 2019 at 08:19:59PM -0700, Eric Dumazet wrote: >> Apparently a refactoring patch brought a bug, that was caught >> by syzbot [1] > > That wasn't refactoring. As you know (because we talked about it at > LSFMM), this is an enabling patc

Re: [PATCH net] tcp: fix slab-out-of-bounds in tcp_zerocopy_receive()

2019-10-03 Thread Matthew Wilcox
On Wed, Oct 02, 2019 at 08:19:59PM -0700, Eric Dumazet wrote: > Apparently a refactoring patch brought a bug, that was caught > by syzbot [1] That wasn't refactoring. As you know (because we talked about it at LSFMM), this is an enabling patch for supporting hch's work to fix get_user_pages(). >

[PATCH net] tcp: fix slab-out-of-bounds in tcp_zerocopy_receive()

2019-10-02 Thread Eric Dumazet
Apparently a refactoring patch brought a bug, that was caught by syzbot [1] Original code was correct, do not try to be smarter than the compiler :/ [1] BUG: KASAN: slab-out-of-bounds in tcp_zerocopy_receive net/ipv4/tcp.c:1807 [inline] BUG: KASAN: slab-out-of-bounds in do_tcp_getsockopt.isra.0+