Re: [PATCH net] tcp: don't read out-of-bounds opsize

2018-04-23 Thread David Miller
From: Jann Horn Date: Fri, 20 Apr 2018 15:57:30 +0200 > The old code reads the "opsize" variable from out-of-bounds memory (first > byte behind the segment) if a broken TCP segment ends directly after an > opcode that is neither EOL nor NOP. > > The result of the read isn't used for anything, so

Re: [PATCH net] tcp: don't read out-of-bounds opsize

2018-04-20 Thread Eric Dumazet
On 04/20/2018 06:57 AM, Jann Horn wrote: > The old code reads the "opsize" variable from out-of-bounds memory (first > byte behind the segment) if a broken TCP segment ends directly after an > opcode that is neither EOL nor NOP. > > The result of the read isn't used for anything, so the worst th

[PATCH net] tcp: don't read out-of-bounds opsize

2018-04-20 Thread Jann Horn
The old code reads the "opsize" variable from out-of-bounds memory (first byte behind the segment) if a broken TCP segment ends directly after an opcode that is neither EOL nor NOP. The result of the read isn't used for anything, so the worst thing that could theoretically happen is a pagefault; a