Re: [PATCH net] sunrpc: fix UDP memory accounting for v4.4 kernel

2019-10-16 Thread JABLONSKY Jan
On Tue, 2019-10-15 at 11:19 +0200, Paolo Abeni wrote: > Hi, > > On Tue, 2019-10-15 at 07:21 +, JABLONSKY Jan wrote: > > The same warnings reported by Jan Stancek may appear also on 4.4 > > Based on Paolo Abeni's work. > > > > WARNING: at net/ipv4/af_inet.c:155 > > CPU: 1 PID: 214 Comm: kworke

Re: [PATCH net] sunrpc: fix UDP memory accounting for v4.4 kernel

2019-10-15 Thread Paolo Abeni
Hi, On Tue, 2019-10-15 at 07:21 +, JABLONSKY Jan wrote: > The same warnings reported by Jan Stancek may appear also on 4.4 > Based on Paolo Abeni's work. > > WARNING: at net/ipv4/af_inet.c:155 > CPU: 1 PID: 214 Comm: kworker/1:1H Not tainted 4.4.166 #1 > Workqueue: rpciod .xprt_autoclose > ta

[PATCH net] sunrpc: fix UDP memory accounting for v4.4 kernel

2019-10-15 Thread JABLONSKY Jan
The same warnings reported by Jan Stancek may appear also on 4.4 Based on Paolo Abeni's work. WARNING: at net/ipv4/af_inet.c:155 CPU: 1 PID: 214 Comm: kworker/1:1H Not tainted 4.4.166 #1 Workqueue: rpciod .xprt_autoclose task: c000366f57c0 ti: c00034134000 task.ti: c00034134000 NIP [c0

Re: [PATCH net] sunrpc: fix UDP memory accounting

2016-08-31 Thread Benjamin Coddington
On 31 Aug 2016, at 7:45, Paolo Abeni wrote: > On Tue, 2016-08-30 at 12:28 -0400, Benjamin Coddington wrote: >> On 25 Aug 2016, at 12:42, Paolo Abeni wrote: >> >>> The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path >>> into a workqueue context"), as a side effect, moved the >>> skb_free_d

Re: [PATCH net] sunrpc: fix UDP memory accounting

2016-08-31 Thread Paolo Abeni
On Tue, 2016-08-30 at 12:28 -0400, Benjamin Coddington wrote: > On 25 Aug 2016, at 12:42, Paolo Abeni wrote: > > > The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path > > into a workqueue context"), as a side effect, moved the > > skb_free_datagram() call outside the scope of the related

Re: [PATCH net] sunrpc: fix UDP memory accounting

2016-08-30 Thread Benjamin Coddington
On 25 Aug 2016, at 12:42, Paolo Abeni wrote: The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path into a workqueue context"), as a side effect, moved the skb_free_datagram() call outside the scope of the related socket lock, but UDP sockets require such lock to be held for proper memory

[PATCH net] sunrpc: fix UDP memory accounting

2016-08-25 Thread Paolo Abeni
The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path into a workqueue context"), as a side effect, moved the skb_free_datagram() call outside the scope of the related socket lock, but UDP sockets require such lock to be held for proper memory accounting. Fix it by replacing skb_free_datagra