Re: [PATCH net] sctp: update frag_point when stream_interleave is set

2018-11-26 Thread Marcelo Ricardo Leitner
On Mon, Nov 26, 2018 at 10:16:50PM +0900, Xin Long wrote: > On Mon, Nov 26, 2018 at 9:29 PM Marcelo Ricardo Leitner > wrote: > > > > On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote: > > > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu > > > changes, but we missed o

Re: [PATCH net] sctp: update frag_point when stream_interleave is set

2018-11-26 Thread Xin Long
On Mon, Nov 26, 2018 at 9:29 PM Marcelo Ricardo Leitner wrote: > > On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote: > > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu > > changes, but we missed one place in sctp_association_init(). It would > > cause frag_point is

Re: [PATCH net] sctp: update frag_point when stream_interleave is set

2018-11-26 Thread Marcelo Ricardo Leitner
On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote: > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu > changes, but we missed one place in sctp_association_init(). It would > cause frag_point is zero when sending data. > > As says in Jakub's reproducer, if sp->pathmtu

[PATCH net] sctp: update frag_point when stream_interleave is set

2018-11-26 Thread Xin Long
sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu changes, but we missed one place in sctp_association_init(). It would cause frag_point is zero when sending data. As says in Jakub's reproducer, if sp->pathmtu is set by socketopt, the new asoc->pathmtu inherits it in sctp_asso