Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

2015-08-25 Thread lucien xin
> > Sorry, you can't do that directly without a lot more checks. The parameer > may be only only partial, or may not be there at all. You'd end up looking > at wrong mememory. > > A better way would be to set the addr_param_seen only when looking at > the first parameter (addip_hdr.params). > I w

Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 06:07 AM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of the > addip params. but we never check if it's really there. if the addr param is > not > there, it still can pass sctp_verify_asconf(), then to be handled by > sctp_process_asconf(),

Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

2015-08-24 Thread Sergei Shtylyov
Hello. On 8/24/2015 1:07 PM, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), i

[PATCH net] sctp: asconf's process should verify address parameter is in the beginning

2015-08-24 Thread Xin Long
in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add a code in sctp_verify