Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-12-04 19:58, Marcelo Ricardo Leitner wrote: > On Tue, Dec 04, 2018 at 07:51:54PM +0100, Jakub Audykowicz wrote: > ... >> Thanks, I've taken your remarks into account and ended up with this >> simple solution: > LGTM! Thanks > >> diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Marcelo Ricardo Leitner
On Tue, Dec 04, 2018 at 07:51:54PM +0100, Jakub Audykowicz wrote: ... > Thanks, I've taken your remarks into account and ended up with this > simple solution: LGTM! Thanks > > diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h > index ab9242e51d9e..3487686f2cf5 100644 > --- a/includ

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-12-04 18:45, Marcelo Ricardo Leitner wrote: > On Tue, Dec 04, 2018 at 06:00:51PM +0100, Jakub Audykowicz wrote: > ... >> OK, let's forget about that "if" :) >> Coming back to the sanity check, I came up with something like below, >> based on the code from sctp_setsockopt_maxseg, like you m

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Marcelo Ricardo Leitner
On Tue, Dec 04, 2018 at 06:00:51PM +0100, Jakub Audykowicz wrote: ... > OK, let's forget about that "if" :) > Coming back to the sanity check, I came up with something like below, > based on the code from sctp_setsockopt_maxseg, like you mentioned. > I may have overcomplicated things since I didn't

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-11-28 12:26, Marcelo Ricardo Leitner wrote: > On Wed, Nov 28, 2018 at 12:08:38AM -0200, Marcelo Ricardo Leitner wrote: >> On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote: >>> On 2018-11-19 08:20, Xin Long wrote: >>> On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz >>>

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-28 Thread Marcelo Ricardo Leitner
On Wed, Nov 28, 2018 at 12:08:38AM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote: > > On 2018-11-19 08:20, Xin Long wrote: > > > > > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz > > > wrote: > > >> Calling send on a connected SCTP soc

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-27 Thread Marcelo Ricardo Leitner
On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote: > On 2018-11-19 08:20, Xin Long wrote: > > > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz > > wrote: > >> Calling send on a connected SCTP socket results in kernel panic if > >> spp_pathmtu was configured manually before an ass

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-27 Thread Jakub Audykowicz
On 2018-11-19 08:20, Xin Long wrote: > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz > wrote: >> Calling send on a connected SCTP socket results in kernel panic if >> spp_pathmtu was configured manually before an association is established >> and it was not reconfigured to another value once t

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-18 Thread Xin Long
On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz wrote: > > Calling send on a connected SCTP socket results in kernel panic if > spp_pathmtu was configured manually before an association is established > and it was not reconfigured to another value once the association is > established. > > Steps

[PATCH net] sctp: always set frag_point on pmtu change

2018-11-18 Thread Jakub Audykowicz
Calling send on a connected SCTP socket results in kernel panic if spp_pathmtu was configured manually before an association is established and it was not reconfigured to another value once the association is established. Steps to reproduce: 1. Set up a listening SCTP server socket. 2. Set up an S