Re: [PATCH net] s390/qeth: reject oversized SNMP requests

2019-08-24 Thread David Miller
From: Julian Wiedmann Date: Fri, 23 Aug 2019 11:29:23 +0200 > Commit d4c08afafa04 ("s390/qeth: streamline SNMP cmd code") removed > the bounds checking for req_len, under the assumption that the check in > qeth_alloc_cmd() would suffice. > > But that code path isn't sufficiently robust to handle

Re: [PATCH net] s390/qeth: reject oversized SNMP requests

2019-08-23 Thread Julian Wiedmann
+cc Dan On 23.08.19 11:29, Julian Wiedmann wrote: > Commit d4c08afafa04 ("s390/qeth: streamline SNMP cmd code") removed > the bounds checking for req_len, under the assumption that the check in > qeth_alloc_cmd() would suffice. > > But that code path isn't sufficiently robust to handle a user-pro

[PATCH net] s390/qeth: reject oversized SNMP requests

2019-08-23 Thread Julian Wiedmann
Commit d4c08afafa04 ("s390/qeth: streamline SNMP cmd code") removed the bounds checking for req_len, under the assumption that the check in qeth_alloc_cmd() would suffice. But that code path isn't sufficiently robust to handle a user-provided data_length, which could overflow (when adding the cmd