Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-09 Thread Heiner Kallweit
On 09.04.2019 20:20, Bjorn Helgaas wrote: > On Tue, Apr 09, 2019 at 07:32:15PM +0200, Heiner Kallweit wrote: >> On 05.04.2019 21:28, Heiner Kallweit wrote: >>> On 05.04.2019 21:10, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote: > On 03.04.2019 15:14,

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-09 Thread Bjorn Helgaas
On Tue, Apr 09, 2019 at 07:32:15PM +0200, Heiner Kallweit wrote: > On 05.04.2019 21:28, Heiner Kallweit wrote: > > On 05.04.2019 21:10, Bjorn Helgaas wrote: > >> On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote: > >>> On 03.04.2019 15:14, Bjorn Helgaas wrote: > On Wed, Apr 03, 2

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-09 Thread Heiner Kallweit
On 05.04.2019 21:28, Heiner Kallweit wrote: > On 05.04.2019 21:10, Bjorn Helgaas wrote: >> On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote: >>> On 03.04.2019 15:14, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: > On 02.04.2019 23:57,

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-05 Thread Heiner Kallweit
On 05.04.2019 21:10, Bjorn Helgaas wrote: > On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote: >> On 03.04.2019 15:14, Bjorn Helgaas wrote: >>> On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: On 02.04.2019 23:57, Bjorn Helgaas wrote: > On Tue, Apr 02, 2019 at

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-05 Thread Bjorn Helgaas
On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote: > On 03.04.2019 15:14, Bjorn Helgaas wrote: > > On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: > >> On 02.04.2019 23:57, Bjorn Helgaas wrote: > >>> On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: > >

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-03 Thread Heiner Kallweit
On 03.04.2019 21:18, Frederick Lawler wrote: > Heiner Kallweit wrote on 4/3/19 12:45 PM: >> On 03.04.2019 15:14, Bjorn Helgaas wrote: >>> [+cc Frederick] >>> >>> On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: On 02.04.2019 23:57, Bjorn Helgaas wrote: > On Tue, Apr 02, 201

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-03 Thread Frederick Lawler
Heiner Kallweit wrote on 4/3/19 12:45 PM: On 03.04.2019 15:14, Bjorn Helgaas wrote: [+cc Frederick] On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: On 02.04.2019 23:57, Bjorn Helgaas wrote: On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: On 02.04.2019 22:16,

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-03 Thread Heiner Kallweit
On 03.04.2019 15:14, Bjorn Helgaas wrote: > [+cc Frederick] > > On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: >> On 02.04.2019 23:57, Bjorn Helgaas wrote: >>> On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: On 02.04.2019 22:16, Florian Fainelli wrote: >

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-03 Thread Bjorn Helgaas
[+cc Frederick] On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote: > On 02.04.2019 23:57, Bjorn Helgaas wrote: > > On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: > >> On 02.04.2019 22:16, Florian Fainelli wrote: > >>> On 4/2/19 12:55 PM, Heiner Kallweit wrote: > >>>

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Heiner Kallweit
On 02.04.2019 23:57, Bjorn Helgaas wrote: > [+cc Rajat] > > On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: >> On 02.04.2019 22:16, Florian Fainelli wrote: >>> On 4/2/19 12:55 PM, Heiner Kallweit wrote: There are numerous reports about different problems caused by ASPM i

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Bjorn Helgaas
[+cc Rajat] On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote: > On 02.04.2019 22:16, Florian Fainelli wrote: > > On 4/2/19 12:55 PM, Heiner Kallweit wrote: > >> There are numerous reports about different problems caused by ASPM > >> incompatibilities between certain network chip ver

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Heiner Kallweit
On 02.04.2019 23:08, Rajat Jain wrote: > On Tue, Apr 2, 2019 at 1:41 PM Heiner Kallweit wrote: >> >> On 02.04.2019 22:16, Florian Fainelli wrote: >>> On 4/2/19 12:55 PM, Heiner Kallweit wrote: There are numerous reports about different problems caused by ASPM incompatibilities between ce

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Rajat Jain
On Tue, Apr 2, 2019 at 1:41 PM Heiner Kallweit wrote: > > On 02.04.2019 22:16, Florian Fainelli wrote: > > On 4/2/19 12:55 PM, Heiner Kallweit wrote: > >> There are numerous reports about different problems caused by ASPM > >> incompatibilities between certain network chip versions and board > >>

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Heiner Kallweit
On 02.04.2019 22:16, Florian Fainelli wrote: > On 4/2/19 12:55 PM, Heiner Kallweit wrote: >> There are numerous reports about different problems caused by ASPM >> incompatibilities between certain network chip versions and board >> chipsets. On the other hand on (especially mobile) systems where AS

Re: [PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Florian Fainelli
On 4/2/19 12:55 PM, Heiner Kallweit wrote: > There are numerous reports about different problems caused by ASPM > incompatibilities between certain network chip versions and board > chipsets. On the other hand on (especially mobile) systems where ASPM > works properly it can significantly contribut

[PATCH net] r8169: switch off ASPM by default and add sysfs attribute to control ASPM

2019-04-02 Thread Heiner Kallweit
There are numerous reports about different problems caused by ASPM incompatibilities between certain network chip versions and board chipsets. On the other hand on (especially mobile) systems where ASPM works properly it can significantly contribute to power-saving and increased battery runtime. On