Re: [PATCH net] ptp_qoriq: Don't write system time into PHC at boot

2019-09-30 Thread Richard Cochran
On Sun, Sep 29, 2019 at 01:22:28AM +0300, Vladimir Oltean wrote: > But I couldn't find a justification to just move the spin_lock_init a > few lines above, because I don't see why the ptp_qoriq_settime call > should be done at all at probe time. Writing a CLOCK_REALTIME value into > a timer that is

Re: [PATCH net] ptp_qoriq: Don't write system time into PHC at boot

2019-09-30 Thread David Miller
From: Vladimir Oltean Date: Sun, 29 Sep 2019 01:22:28 +0300 > Because ptp_qoriq_settime is being called prior to spin_lock_init, the > following stack trace can be seen at driver probe time: > > [2.269117] the code is fine but needs lockdep annotation. > [2.274569] turning off the lockin

[PATCH net] ptp_qoriq: Don't write system time into PHC at boot

2019-09-28 Thread Vladimir Oltean
Because ptp_qoriq_settime is being called prior to spin_lock_init, the following stack trace can be seen at driver probe time: [2.269117] the code is fine but needs lockdep annotation. [2.274569] turning off the locking correctness validator. [2.280027] CPU: 1 PID: 1 Comm: swapper/0 No