Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Eric Dumazet
On Fri, Mar 24, 2017 at 7:10 PM, David Miller wrote: > > > Eric, please add a proper signoff for yourself, and also please > add the following tag: > > Reported-by: Daniel Jiang Oh right, will send a v2 immediately. Thanks.

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread David Miller
From: Eric Dumazet Date: Fri, 24 Mar 2017 16:29:45 -0700 > From: Eric Dumazet > > We got a report of yet another bug in ping > > http://www.openwall.com/lists/oss-security/2017/03/24/6 > > ->disconnect() is not called with socket lock held. > > Fix this by acquiring ping rwlock earlier. > >

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Xose Vazquez Perez
Solar Designer wrote: > We should credit the original reporter, who most likely found this by > fuzzing. It's danieljiang0415 on GitHub and Twitter. Unfortunately, I > don't know their e-mail address. I'll try asking. Daniel Jiang

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Solar Designer
On Fri, Mar 24, 2017 at 04:29:45PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > We got a report of yet another bug in ping > > http://www.openwall.com/lists/oss-security/2017/03/24/6 > > ->disconnect() is not called with socket lock held. > > Fix this by acquiring ping rwlock earlier. >

[PATCH net] ping: implement proper locking

2017-03-24 Thread Eric Dumazet
From: Eric Dumazet We got a report of yet another bug in ping http://www.openwall.com/lists/oss-security/2017/03/24/6 ->disconnect() is not called with socket lock held. Fix this by acquiring ping rwlock earlier. Thanks to Alexander and Andrey for letting us know of this problem. Fixes: c319