Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

2016-11-23 Thread Florian Fainelli
Le 23/11/2016 à 13:39, woojung@microchip.com a écrit : > From: Woojung Huh > > When phy_init_hw() fails at phy_attach_direct(); > - phy_detach() calls phy_led_triggers_unregister() without > previous call of phy_led_triggers_register(). > - still call phy_led_triggers_register() and cause

Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

2016-11-23 Thread Andrew Lunn
On Wed, Nov 23, 2016 at 09:39:37PM +, woojung@microchip.com wrote: > From: Woojung Huh > > When phy_init_hw() fails at phy_attach_direct(); > - phy_detach() calls phy_led_triggers_unregister() without > previous call of phy_led_triggers_register(). > - still call phy_led_triggers_regis

Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

2016-11-23 Thread Sergei Shtylyov
Hello. On 11/24/2016 12:39 AM, woojung@microchip.com wrote: From: Woojung Huh When phy_init_hw() fails at phy_attach_direct(); - phy_detach() calls phy_led_triggers_unregister() without previous call of phy_led_triggers_register(). - still call phy_led_triggers_register() and cause memo

[PATCH net] phy: fix error case of phy_led_triggers_(un)register

2016-11-23 Thread Woojung.Huh
From: Woojung Huh When phy_init_hw() fails at phy_attach_direct(); - phy_detach() calls phy_led_triggers_unregister() without previous call of phy_led_triggers_register(). - still call phy_led_triggers_register() and cause memory leak. Signed-off-by: Woojung Huh --- drivers/net/phy/phy_devi