Re: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-29 Thread Willem de Bruijn
On Mon, Apr 29, 2019 at 9:19 AM David Laight wrote: > > > Can then also change memset to zero only two bytes in the Ethernet case. > > > > + if (msg->msg_namelen < sizeof(struct sockaddr_ll)) { > > + msg->msg_namelen = sizeof(struct > > sockaddr

RE: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-29 Thread David Laight
> Can then also change memset to zero only two bytes in the Ethernet case. > > + if (msg->msg_namelen < sizeof(struct sockaddr_ll)) { > + msg->msg_namelen = sizeof(struct sockaddr_ll); > + memset(msg->msg_name + copy

Re: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-29 Thread Willem de Bruijn
On Mon, Apr 29, 2019 at 5:03 AM David Laight wrote: > > From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] > > Sent: 26 April 2019 20:30 > > Packet send checks that msg_name is at least sizeof sockaddr_ll. > > Packet recv must return at least this length, so that its output > > can be

RE: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-29 Thread David Laight
From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] > Sent: 26 April 2019 20:30 > Packet send checks that msg_name is at least sizeof sockaddr_ll. > Packet recv must return at least this length, so that its output > can be passed unmodified to packet send. > > This ceased to be true si

Re: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-26 Thread Willem de Bruijn
On Fri, Apr 26, 2019 at 3:29 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > Packet send checks that msg_name is at least sizeof sockaddr_ll. > Packet recv must return at least this length, so that its output > can be passed unmodified to packet send. > > This ceased to be true since ad

[PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-26 Thread Willem de Bruijn
From: Willem de Bruijn Packet send checks that msg_name is at least sizeof sockaddr_ll. Packet recv must return at least this length, so that its output can be passed unmodified to packet send. This ceased to be true since adding support for lladdr longer than sll_addr. Since, the return value u