Re: [PATCH net] netlink: extack needs to be reset each time through loop

2018-01-15 Thread David Miller
From: David Ahern Date: Wed, 10 Jan 2018 13:00:39 -0800 > syzbot triggered the WARN_ON in netlink_ack testing the bad_attr value. > The problem is that netlink_rcv_skb loops over the skb repeatedly invoking > the callback and without resetting the extack leaving potentially stale > data. Initiali

[PATCH net] netlink: extack needs to be reset each time through loop

2018-01-10 Thread David Ahern
syzbot triggered the WARN_ON in netlink_ack testing the bad_attr value. The problem is that netlink_rcv_skb loops over the skb repeatedly invoking the callback and without resetting the extack leaving potentially stale data. Initializing each time through avoids the WARN_ON. Fixes: 2d4bc93368f5a (