Re: [PATCH net] net: test tailroom before appending to linear skb

2018-05-17 Thread Willem de Bruijn
On Thu, May 17, 2018 at 12:44 PM, Eric Dumazet wrote: > > > On 05/17/2018 08:54 AM, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Device features may change during transmission. In particular with >> corking, a device may toggle scatter-gather in between allocating >> and writing to an

Re: [PATCH net] net: test tailroom before appending to linear skb

2018-05-17 Thread Eric Dumazet
On 05/17/2018 08:54 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Device features may change during transmission. In particular with > corking, a device may toggle scatter-gather in between allocating > and writing to an skb. > > Do not unconditionally assume that !NETIF_F_SG at wri

Re: [PATCH net] net: test tailroom before appending to linear skb

2018-05-17 Thread Eric Dumazet
On 05/17/2018 08:54 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Device features may change during transmission. In particular with > corking, a device may toggle scatter-gather in between allocating > and writing to an skb. > > Do not unconditionally assume that !NETIF_F_SG at wri

[PATCH net] net: test tailroom before appending to linear skb

2018-05-17 Thread Willem de Bruijn
From: Willem de Bruijn Device features may change during transmission. In particular with corking, a device may toggle scatter-gather in between allocating and writing to an skb. Do not unconditionally assume that !NETIF_F_SG at write time implies that the same held at alloc time and thus the sk