Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Florian Fainelli
On 12/21/2020 2:25 PM, Vladimir Oltean wrote: > On Mon, Dec 21, 2020 at 01:49:03PM -0800, Florian Fainelli wrote: >> On 12/18/2020 1:17 PM, Florian Fainelli wrote: > SYSTEMPORT Lite does not actually validate the frame length, so > setting > a maximum number to the buffe

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Vladimir Oltean
On Mon, Dec 21, 2020 at 01:49:03PM -0800, Florian Fainelli wrote: > On 12/18/2020 1:17 PM, Florian Fainelli wrote: > >>> SYSTEMPORT Lite does not actually validate the frame length, so > >>> setting > >>> a maximum number to the buffer size we allocate could work, but I > >>> don'

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Florian Fainelli
On 12/18/2020 1:17 PM, Florian Fainelli wrote: >>> SYSTEMPORT Lite does not actually validate the frame length, so setting >>> a maximum number to the buffer size we allocate could work, but I don't >>> see a reason to differentiate the two types of MACs here. >> >> And if th

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 1:14 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote: >> On 12/18/20 1:02 PM, Vladimir Oltean wrote: >>> On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: On 12/18/20 12:52 PM, Vladimir Oltean wrote: > On Fri, Dec 18

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Vladimir Oltean
On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote: > On 12/18/20 1:02 PM, Vladimir Oltean wrote: > > On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: > >> On 12/18/20 12:52 PM, Vladimir Oltean wrote: > >>> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wr

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 1:02 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: >> On 12/18/20 12:52 PM, Vladimir Oltean wrote: >>> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: On 12/18/20 12:24 PM, Vladimir Oltean wrote: > Hi Florian, >

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Vladimir Oltean
On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: > On 12/18/20 12:52 PM, Vladimir Oltean wrote: > > On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: > >> On 12/18/20 12:24 PM, Vladimir Oltean wrote: > >>> Hi Florian, > >>> > >>> On Fri, Dec 18, 2020 at 09:38:43AM -

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 12:52 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: >> On 12/18/20 12:24 PM, Vladimir Oltean wrote: >>> Hi Florian, >>> >>> On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: The driver is already allocating receive bu

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Vladimir Oltean
On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: > On 12/18/20 12:24 PM, Vladimir Oltean wrote: > > Hi Florian, > > > > On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: > >> The driver is already allocating receive buffers of 2KiB and the > >> Ethernet MAC is conf

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 12:24 PM, Vladimir Oltean wrote: > Hi Florian, > > On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: >> The driver is already allocating receive buffers of 2KiB and the >> Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE. >> >> Fixes: bfcb813203e6 ("n

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Vladimir Oltean
Hi Florian, On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: > The driver is already allocating receive buffers of 2KiB and the > Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE. > > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") > Signed

[PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
The driver is already allocating receive buffers of 2KiB and the Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE. Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 1 + 1 file