Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Sep 2017 14:28:40 -0700 > FYI, there is another patch needed to ensure consistency between > ethtool reported stats and netdevice stats, will submit that after > some more testing. Thanks! Yes, I saw that, th anks.

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-15 Thread Florian Fainelli
On September 15, 2017 2:25:11 PM PDT, David Miller wrote: >From: Florian Fainelli >Date: Tue, 12 Sep 2017 13:14:26 -0700 > >> We can enter a deadlock situation because there is no sufficient >protection >> when ndo_get_stats64() runs in process context to guard against RX or >TX NAPI >> contexts

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-15 Thread David Miller
From: Florian Fainelli Date: Tue, 12 Sep 2017 13:14:26 -0700 > We can enter a deadlock situation because there is no sufficient protection > when ndo_get_stats64() runs in process context to guard against RX or TX NAPI > contexts running in softirq, this can lead to the following lockdep splat an

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Florian Fainelli
On 09/12/2017 02:38 PM, Eric Dumazet wrote: > On Tue, 2017-09-12 at 13:14 -0700, Florian Fainelli wrote: >> We can enter a deadlock situation because there is no sufficient protection >> when ndo_get_stats64() runs in process context to guard against RX or TX NAPI >> contexts running in softirq, th

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Eric Dumazet
On Tue, 2017-09-12 at 13:14 -0700, Florian Fainelli wrote: > We can enter a deadlock situation because there is no sufficient protection > when ndo_get_stats64() runs in process context to guard against RX or TX NAPI > contexts running in softirq, this can lead to the following lockdep splat and >

[PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Florian Fainelli
We can enter a deadlock situation because there is no sufficient protection when ndo_get_stats64() runs in process context to guard against RX or TX NAPI contexts running in softirq, this can lead to the following lockdep splat and actual deadlock was experienced as well with an iperf session in th