Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-24 Thread David Miller
From: Eric Dumazet Date: Wed, 18 Sep 2019 12:57:04 -0700 > If the allocation done in tcf_exts_init() failed, > we end up with a NULL pointer in exts->actions. ... > Fixes: 90b73b77d08e ("net: sched: change action API to use array of pointers > to actions") > Signed-off-by: Eric Dumazet > Repor

Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-23 Thread Cong Wang
On Mon, Sep 23, 2019 at 8:44 AM Eric Dumazet wrote: > > > > On 9/21/19 7:08 PM, Jakub Kicinski wrote: > > On Wed, 18 Sep 2019 14:37:21 -0700, Cong Wang wrote: > >> On Wed, Sep 18, 2019 at 12:57 PM 'Eric Dumazet' via syzkaller > >> wrote: > >>> > >>> If the allocation done in tcf_exts_init() faile

Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-23 Thread Eric Dumazet
On 9/21/19 7:08 PM, Jakub Kicinski wrote: > On Wed, 18 Sep 2019 14:37:21 -0700, Cong Wang wrote: >> On Wed, Sep 18, 2019 at 12:57 PM 'Eric Dumazet' via syzkaller >> wrote: >>> >>> If the allocation done in tcf_exts_init() failed, >>> we end up with a NULL pointer in exts->actions. >> ... >>>

Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-21 Thread Jakub Kicinski
On Wed, 18 Sep 2019 14:37:21 -0700, Cong Wang wrote: > On Wed, Sep 18, 2019 at 12:57 PM 'Eric Dumazet' via syzkaller > wrote: > > > > If the allocation done in tcf_exts_init() failed, > > we end up with a NULL pointer in exts->actions. > ... > > diff --git a/net/sched/cls_api.c b/net/sched/cls_a

Re: [PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-18 Thread Cong Wang
On Wed, Sep 18, 2019 at 12:57 PM 'Eric Dumazet' via syzkaller wrote: > > If the allocation done in tcf_exts_init() failed, > we end up with a NULL pointer in exts->actions. ... > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index > efd3cfb80a2ad775dc8ab3c4900bd73d52c7aaad..9aef93300f1

[PATCH net] net: sched: fix possible crash in tcf_action_destroy()

2019-09-18 Thread Eric Dumazet
If the allocation done in tcf_exts_init() failed, we end up with a NULL pointer in exts->actions. kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 8198 Comm: syz-executor.3 Not tainted 5.3.0-rc8+ #0 Hardware name: