Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Jiri Pirko
Tue, Sep 05, 2017 at 04:25:51PM CEST, kubak...@wp.pl wrote: >On Tue, 5 Sep 2017 14:52:21 +0200, Jiri Pirko wrote: >> Tue, Sep 05, 2017 at 12:59:48PM CEST, kubak...@wp.pl wrote: >> >Jiri, FWIW I also just noticed these, but they seem related to the >> >earlier TC chain work? >> >> What do you do

Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Jakub Kicinski
On Tue, 5 Sep 2017 14:52:21 +0200, Jiri Pirko wrote: > Tue, Sep 05, 2017 at 12:59:48PM CEST, kubak...@wp.pl wrote: > >Jiri, FWIW I also just noticed these, but they seem related to the > >earlier TC chain work? > > What do you do to trigger this? Sorry, I wasted a bit of time there because kmem

Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Eric Dumazet
On Tue, 2017-09-05 at 03:54 -0700, Jakub Kicinski wrote: > The new TC IDR code uses GFP_KERNEL under spinlocks. Which leads > to: > ... > > Fixes: 65a206c01e8e ("net/sched: Change act_api and act_xxx modules to use > IDR") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman > --- > n

Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Jiri Pirko
Tue, Sep 05, 2017 at 12:59:48PM CEST, kubak...@wp.pl wrote: >Jiri, FWIW I also just noticed these, but they seem related to the >earlier TC chain work? What do you do to trigger this? > >unreferenced object 0x8807466f70c8 (size 64): > comm "tc", pid 1812, jiffies 4294932641 (age 1537.192s) >

Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Jakub Kicinski
Jiri, FWIW I also just noticed these, but they seem related to the earlier TC chain work? unreferenced object 0x8807466f70c8 (size 64): comm "tc", pid 1812, jiffies 4294932641 (age 1537.192s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 a0 83 e1 31 07 88 ff ff ...1

[PATCH net] net: sched: don't use GFP_KERNEL under spin lock

2017-09-05 Thread Jakub Kicinski
The new TC IDR code uses GFP_KERNEL under spinlocks. Which leads to: [ 582.621091] BUG: sleeping function called from invalid context at ../mm/slab.h:416 [ 582.629721] in_atomic(): 1, irqs_disabled(): 0, pid: 3379, name: tc [ 582.636939] 2 locks held by tc/3379: [ 582.641049] #0: (rtnl_mut